Feature/color macros mordernization#370
Conversation
Walkthrough将颜色类型 Changes颜色定义提取到独立头文件
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: This PR modernizes EGE color utilities by moving the color type and helper definitions into a dedicated header. Changes:
Technical Notes: Switching from macros to 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@include/ege/color.h`:
- Around line 8-12: The public API still refers to bare color_t, but the type
was moved into the ege namespace, so compilation breaks unless it is re-exported
globally. Update include/ege/color.h to add a global using ege::color_t
alongside the existing function re-exports, and make sure the same public-facing
symbol is available to include/ege.h and include/ege.zh_CN.h where color_t is
used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a220b8ac-4a33-46c6-bafe-59f6993c4bc5
📒 Files selected for processing (4)
.gitignoreinclude/ege.hinclude/ege.zh_CN.hinclude/ege/color.h
Summary by CodeRabbit
.cache/目录的忽略。