Skip to content

Remove unused lodash.#44

Open
kylev wants to merge 1 commit into
wmerkens:mainfrom
kylev:kv_nodash
Open

Remove unused lodash.#44
kylev wants to merge 1 commit into
wmerkens:mainfrom
kylev:kv_nodash

Conversation

@kylev

@kylev kylev commented May 22, 2026

Copy link
Copy Markdown

libraryManager.ts never actually used it, and nothing else remaining does.

Also corrects missing changes to package-lock.json and a little whitespace.

libraryManager.ts never actually used it, and nothing else remaining does.
Copilot AI review requested due to automatic review settings May 22, 2026 20:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the project’s direct dependency on lodash by deleting an unused import in the library manager and dropping lodash / @types/lodash from the extension’s package manifests.

Changes:

  • Removed the unused lodash import from src/librarymanager/libraryManager.ts.
  • Removed lodash and @types/lodash from package.json.
  • Updated package-lock.json to reflect dependency graph changes (but also includes an @types/vscode update).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/librarymanager/libraryManager.ts Drops unused lodash import.
package.json Removes lodash and @types/lodash; trims a trailing whitespace in a menu contribution.
package-lock.json Removes direct lodash entries but also bumps/changes VS Code typings resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package-lock.json
"@types/node": "^24.0.3",
"@types/serialport": "^8.0.5S",
"@types/vscode": "^1.101.0",
"@types/vscode": "^1.103.1",

@kylev kylev May 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like part of package-lock.json didn't get committed with 6f6f84a. Like maybe npm i got run after the engines change but not the devDependency bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants