Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/interact/src/core/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,16 @@ function effectToCSS(
media,
selectorCondition,
childSelector,
declarations: animationDeclarations.concat(DEFAULT_INITIAL),
addInitialSelector: true,
declarations: DEFAULT_INITIAL,
dataInteractEnterSelector: ':not([data-interact-enter])',
});
rules.push({
key,
media,
selectorCondition,
childSelector,
declarations: animationDeclarations,
dataInteractEnterSelector: ':not([data-interact-enter="done"])',
});
} else {
// declare animation and composition custom properties
Expand Down
15 changes: 11 additions & 4 deletions packages/interact/src/core/cssUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,15 @@ export function keyframesToCSS(name: string, keyframes: Keyframe[]): string {
}

export function CSSRuleToString(rule: CSSRuleData): string {
const { key, childSelector, declarations, media, states, selectorCondition, addInitialSelector } =
rule;
const {
key,
childSelector,
declarations,
media,
states,
selectorCondition,
dataInteractEnterSelector,
} = rule;
if (!declarations.length) {
return '';
}
Expand All @@ -123,8 +130,8 @@ export function CSSRuleToString(rule: CSSRuleData): string {
selector = `${selector} ${childSelector}`;
}

if (addInitialSelector) {
selector = `${selector}:not([data-interact-enter])`;
if (dataInteractEnterSelector) {
selector = `${selector}${dataInteractEnterSelector}`;
}

// maybe nesting is simpler? -
Expand Down
2 changes: 1 addition & 1 deletion packages/interact/src/types/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ export type CSSRuleData = {
media?: string;
states?: string[];
selectorCondition?: string;
addInitialSelector?: boolean;
dataInteractEnterSelector?: string;
};
23 changes: 16 additions & 7 deletions packages/interact/test/css.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,9 @@ describe('css._generate', () => {

const { cssRules } = _generate(config);

const initialRule = cssRules.find((r) => r.addInitialSelector)!;
const initialRule = cssRules.find(
(r) => r.dataInteractEnterSelector === ':not([data-interact-enter])',
)!;
expect(initialRule).toBeDefined();

DEFAULT_INITIAL.forEach(({ name, value }) => {
Expand All @@ -444,7 +446,12 @@ describe('css._generate', () => {
expect(decl!.value).toBe(value);
});

const animDeclOnInitial = findDecl(initialRule.declarations, (d) => isAnimationProp(d.name));
const animationRule = cssRules.find(
(r) => r.dataInteractEnterSelector === ':not([data-interact-enter="done"])',
)!;
const animDeclOnInitial = findDecl(animationRule.declarations, (d) =>
isAnimationProp(d.name),
);
expect(animDeclOnInitial).toBeDefined();
expect(animDeclOnInitial!.value).toContain('myAnim');
});
Expand Down Expand Up @@ -472,7 +479,7 @@ describe('css._generate', () => {

const { cssRules } = _generate(config);

expect(cssRules.every((r) => !r.addInitialSelector)).toBe(true);
expect(cssRules.every((r) => !r.dataInteractEnterSelector)).toBe(true);

const effectRule = cssRules.find((r) => r.declarations.some((d) => isAnimationProp(d.name)))!;
expect(effectRule).toBeDefined();
Expand All @@ -492,7 +499,7 @@ describe('css._generate', () => {

const { cssRules } = _generate(config);

expect(cssRules.every((r) => !r.addInitialSelector)).toBe(true);
expect(cssRules.every((r) => !r.dataInteractEnterSelector)).toBe(true);
});
});

Expand Down Expand Up @@ -654,7 +661,7 @@ describe('css._generate', () => {

const { cssRules } = _generate(config);

expect(cssRules.every((r) => !r.addInitialSelector)).toBe(true);
expect(cssRules.every((r) => !r.dataInteractEnterSelector)).toBe(true);
});

it('should emit auto duration in animation shorthand for viewProgress (SSR-safe)', () => {
Expand Down Expand Up @@ -796,7 +803,9 @@ describe('css._generate', () => {

const { cssRules } = _generate(config);

const initialRule = cssRules.find((r) => r.addInitialSelector)!;
const initialRule = cssRules.find(
(r) => r.dataInteractEnterSelector === ':not([data-interact-enter="done"])',
)!;
expect(initialRule).toBeDefined();

const timelineDecl = findDecl(initialRule.declarations, (d) => isTimelineProp(d.name));
Expand Down Expand Up @@ -1150,7 +1159,7 @@ describe('css._generate', () => {
};

const { cssRules } = _generate(config);
const initialRule = cssRules.find((r) => r.addInitialSelector)!;
const initialRule = cssRules.find((r) => r.dataInteractEnterSelector)!;

expect(initialRule).toBeDefined();
expect(initialRule.media).toContain('min-width: 1024px');
Expand Down
11 changes: 6 additions & 5 deletions packages/interact/test/cssUtils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,14 @@ describe('CSSRuleToString', () => {
expect(CSSRuleToString(rule)).toEqual(expected);
});

it('should add :not([data-interact-enter]) when addInitialSelector is true', () => {
it('should dataInteractEnterSelector when provided', () => {
const rule: CSSRuleData = {
key: 'my-el',
addInitialSelector: true,
dataInteractEnterSelector: ':not([data-interact-enter="done"])',
declarations: [{ name: 'opacity', value: '0' }],
};
const expected = '[data-interact-key="my-el"]:not([data-interact-enter]) {\nopacity: 0;\n}';
const expected =
'[data-interact-key="my-el"]:not([data-interact-enter="done"]) {\nopacity: 0;\n}';
expect(CSSRuleToString(rule)).toEqual(expected);
});

Expand Down Expand Up @@ -253,7 +254,7 @@ describe('CSSRuleToString', () => {
const rule: CSSRuleData = {
key: 'my-el',
childSelector: '.child',
addInitialSelector: true,
dataInteractEnterSelector: ':not([data-interact-enter="done"])',
states: ['hover'],
media: '(min-width: 1024px)',
declarations: [
Expand All @@ -262,7 +263,7 @@ describe('CSSRuleToString', () => {
],
};
const expected =
'@media (min-width: 1024px) {\n[data-interact-key="my-el"]:is(:state(hover), :--hover, [data-interact-effect~="hover"]) .child:not([data-interact-enter]) {\nopacity: 1;\ncolor: blue;\n}\n}';
'@media (min-width: 1024px) {\n[data-interact-key="my-el"]:is(:state(hover), :--hover, [data-interact-effect~="hover"]) .child:not([data-interact-enter="done"]) {\nopacity: 1;\ncolor: blue;\n}\n}';
expect(CSSRuleToString(rule)).toEqual(expected);
});
});
Expand Down
Loading