Skip to content

feat(pty): add Windows ConPTY provider - #60

Open
passcod wants to merge 114 commits into
mainfrom
feat/windows-pty-provider
Open

feat(pty): add Windows ConPTY provider#60
passcod wants to merge 114 commits into
mainfrom
feat/windows-pty-provider

Conversation

@passcod

@passcod passcod commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🤖 Adds a native Windows ConPTY backend for the Tokio Pty provider while retaining the ordinary .wrap(Pty).spawn() API.

The backend resolves ConPTY at runtime, uses Tokio named-pipe I/O, performs exact CreateProcessW startup, and provides custom child/controller ownership, transactional cleanup, resize support, and cancellation-safe repeated waits. It composes with creation flags, JobObject supervision, and kill-on-drop behavior.

Windows PTY support requires Windows 11 24H2 build 26100 or Windows Server 2025 because descendant-aware output EOF depends on ReleasePseudoConsole. Call Pty::check_supported() or Pty::is_supported() for platform/runtime capability; command, configuration, wrapper, and spawn validation remain separate.

🤖 Generated with Claude Code

passcod and others added 30 commits September 24, 2026 22:50
@passcod @claude
plan: clarify ConPTY support contract
79aaa49 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
plan: expose PTY capability queries
fda4566 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
plan: map ConPTY recovery sequence
40fcd85 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
plan: decompose ConPTY recovery tasks
d0eb580 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
plan: separate ConPTY recovery from capability API
c852725 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
feat(pty): resolve Windows executables
ea89dbd 
Port deterministic Windows executable resolution and direct batch-script
rejection from revisions 0115823 and 52dae07. Consume the
shared program and effective environment getters without restoring a PTY-local
command model.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): resolve ConPTY capabilities dynamically
4f8132e 
Port the complete runtime capability set from revisions df66fb7,
193d16f, and 2bc7ab1. Resolve all four exports without adding them to
the crate static import table, preserving Unsupported behavior on older
Windows runtimes.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): create ConPTY named pipes
5f43231 
Port the synchronous ConPTY endpoints and overlapped Tokio host endpoints
from revisions 6150ae8 and 880ce4f. Keep every handle non-inheritable
and use unique local byte-mode pipe instances.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): own ConPTY startup state
5c7715c 
Port aligned pseudo-console attributes and dynamically owned HPCON lifecycle
from revisions 0321b10, 33ba7f8, 6a76438, 9ff3db3,
2bc7ab1, 7e42c7e, and 6612441. Preserve idempotent startup
release, resizing after release, and off-thread final close.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): own ConPTY child processes
8ff220c 
Port direct Win32 child ownership, exact primary-thread resume, and
cancellation-safe repeated waits from revisions 92c683c, fdbd3e7,
0a65307, and 5a52698. Adapt the child to current process-handle and
resume capabilities, retaining armed process cleanup until finalization.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): share ConPTY controller ownership
e4fe2ce 
Port strong input/output and weak resize ownership from revision bc8f3ab.
Duplicate both host pipe handles into the shared master so either public I/O
half can keep the complete pseudo-console transport alive.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): create ConPTY processes exactly
27f50b1 
Port manual CreateProcessW assembly and defensive malformed-output cleanup
from revisions a2571ef and 6612441. Adapt creation flags and direct
kill-on-drop to WindowsSpawnPolicy while retaining independent rollback
ownership for the provider lifecycle.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
feat(pty): integrate ConPTY spawn provider
ad4e1f1 
Adapt backend assembly from revisions 07ca549, b2df8b6, 7e42c7e,
and 6612441 to the shared SpawnAttempt and ProviderProduct lifecycle. Keep
process rollback and controller visibility armed through public hooks and all
internal Windows finalization, with wrapper-native one-shot extraction.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
test(pty): adopt wrapper-native ConPTY API
be2be8a 
Restore the native Windows transport coverage through Command::wrap(Pty),
one-shot controller extraction, portable wrappers, and reusable tracked state.
Exclude supported Windows from the unsupported-backend suite.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
test(pty): cover ConPTY lifecycle failures
40cfb1f 
Exercise controller commit gating, real child and descendant cleanup across
hook and Windows finalization errors and panics, provider conflicts, command
reuse, duplicate registration, wrapper order, and terminal capabilities.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
fix(pty): let ConPTY install standard handles
6ac03ba 
Leave STARTUPINFO standard-handle flags clear when attaching the
pseudoconsole attribute. STARTF_USESTDHANDLES requires valid inheritable
handles and is not part of the documented ConPTY startup sequence.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
fix(pty): release canceled ConPTY waits
92c085e 
Co-Authored-By: Claude <noreply@anthropic.com>
@passcod @claude
fix(pty): detach ConPTY waits from Tokio runtimes
314cb30 
Move cancellation-safe process waits onto a dedicated OS thread so a retained child cannot hold a Tokio blocking pool open during runtime shutdown.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@passcod @claude
fix(job-object): keep rollback armed through finalization
c59cc98 
Defer the exact JobObject cleanup owner until every other child-layer finalization hook has succeeded, and isolate descendant cleanup regressions from console or ConPTY closure.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@passcod @claude
feat(pty): expose backend capability queries
b78fc3b 
Expose PTY backend availability without requiring a configured spawn.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(pty): cover capability queries across targets
c63b767 
Run the focused unsupported-target test through cross-compilation and cover Windows runtime availability.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
fix(pty): attach ConPTY standard handles
9c8469a 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
docs(pty): document Windows ConPTY support
a1aedf6 
Describe the supported Windows floor and conditional PTY capability API.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
fix(pty): release ConPTY startup before hooks
a480ad1 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
revert: retain ConPTY startup release until commit
bf2544e 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(pty): diagnose pre-commit ConPTY child failure
3e8865e 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(pty): wait for descendants after ConPTY commit
29ed0fb 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(pty): cover post-exit ConPTY kills
f9f6f40 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(pty): remove invalid pre-return descendant case
3ad8858 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
fix(pty): reap failed ConPTY spawns off-thread
4a7a76c 
Co-Authored-By: Claude Code <noreply@anthropic.com>
passcod and others added 12 commits September 28, 2026 17:30
@passcod @claude
test(miri): ignore native signal seam fixtures
e9f55b2 
Mark the new direct-child syscall seam tests as native-process cases so process-free Miri validation continues to model only supported state and ownership paths.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
style(pty): simplify rollback kill error guard
1a04500 
Express the ignored InvalidInput rollback case as one conditional so strict Clippy can validate the touched PTY cleanup path without a broad allowance.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
style(windows): normalize PTY validation paths
7c58341 
Collapse executable-search branches, use captured test formatting, and document the narrow serial fault-injection lock allowance required by strict target Clippy.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(tracing): isolate lifecycle subscriber regressions
4723138 
Run generic lifecycle subscriber assertions in bounded subprocesses so tracing callsite-cache updates from concurrent tests cannot suppress the targeted event.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): prove prepared reader publication ordering
d3d2ebf 
Require spawn success before active-reader release and place active plus upgraded queued readers through the real native/provider lifecycle with bounded close, rollback, disposal, and reuse evidence.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(unix): make shared signalling proof deterministic
a9ccd1a 
Use explicit terminal release and bounded observable wait/signal workers under one lower-child mutex, and guard every native syscall-seam child with unconditional kill/reap cleanup.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): prove JobObject drain resource closure
27a6cca 
Attribute complete handle closure to authoritative drain under persistent disarm failure with a live tree, and sample repeated drained extraction through native process handle counts.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): prove watchdog stall readiness
7fa65ec 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(ci): lock downstream README fixtures
ac94c4f 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): isolate JobObject custodian assertions
b893f2a 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): own prepared reader setup workers
213e282 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(unix): prove signal mutex acquisition
111e50f 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod
passcod force-pushed the feat/windows-pty-provider branch from 4c078ac to 111e50f Compare September 28, 2026 04:53
passcod and others added 3 commits September 28, 2026 23:00
@passcod @claude
test(windows): measure warmed handle slope
6da0932 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
ci: add explicit major-release semver path
ea5d450 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
ci: restrict major baseline to base ancestry
2536d17 
Co-Authored-By: Claude Code <noreply@anthropic.com>
passcod and others added 11 commits September 29, 2026 00:35
@passcod @claude
ci: keep semver compatibility checks strict
dde5378 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): decouple JobObject extraction fixture
1d50d7c 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
fix(windows): preserve JobObject limit state
ad52bbe 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
fix(windows): verify JobObject extraction disarm
e8ed9ee 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): prove terminal JobObject set ordering
6a4d416 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): extend terminal ordering coverage
cbbf9af 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
test(windows): distinguish final-owner call attempts
9202477 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
ci: check out exact triggering head
1224562 
Pin every workflow checkout to the immutable pull-request head SHA, falling back to the push SHA, while preserving checkout depth and credential settings.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
docs: distinguish live and spawned child identity
a4a47de 
Document Tokio child IDs as live-facing rather than universal liveness proof, and align the std and Tokio installation-only historical PID contracts for custom providers.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
docs: require terminal spawned identity capability
627a5a2 
Clarify that every supervision-capable self-terminal custom child must advertise its historical installation PID, while transparent wrappers may traverse to a lower capability.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod @claude
unplan: command API and PTY provider
474aefe 
Co-Authored-By: Claude Code <noreply@anthropic.com>
@passcod
passcod marked this pull request as ready for review October 1, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@passcod