Repository navigation
Run the acceptance specs in rake acceptance - #61
Merged
Merged
Conversation
The acceptance task's pattern pointed at spec/unit, so CI ran the unit specs twice and never ran spec/acceptance. Point it at spec/acceptance. Two acceptance specs had gone stale while they were not running: - The Markdown expectation ended with a blank line that the output has not had since voxpupuli#49 normalized trailing newlines. - The enum tag expectation required a newline before </div>. YARD 0.9.40 added a built-in Markdown renderer that is preferred over redcarpet and omits it. Match the part both renderers produce. Also remove spec/spec_helper_acceptance_local.rb. Nothing has loaded it since Litmus was removed, and it calls Litmus's run_shell. Fixes voxpupuli#59 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rake acceptanceranspec/unit/**/*.rb, so the "Run acceptance tests" step in CI ran the unit specs a second time andspec/acceptancenever ran. This points the task atspec/acceptance/**/*_spec.rband fixes the two specs that went stale while they were not running.Rakefile: theacceptancepattern is nowspec/acceptance/**/*_spec.rb.generate_markdown_spec.rb: the expected Markdown no longer ends with a blank line. The output has not had one since (bug) Normalize markdown output whitespace and trailing newline #49.running_strings_generate_spec.rb: the enum tag expectation no longer requires a newline before</div>. YARD 0.9.40 added a built-in Markdown renderer,HybridMarkdown, which is preferred over redcarpet and leaves that newline out. The gemspec allows anyyard ~> 0.9, so the expectation now matches the part both renderers produce.spec/spec_helper_acceptance_local.rbis deleted. Nothing has loaded it since Litmus was removed in f135335, and it calls Litmus'srun_shell.Additional Context
Run locally on Ruby 3.4.8 with openvox 9.0.0:
bundle exec rake acceptancebundle exec rspec spec/acceptancebundle exec rakebundle exec rake rubocopThe 2 pending acceptance examples were already marked
skip.The README's acceptance section is being updated separately in #60.
Related Issues (if any)
Fixes #59
Checklist
Assisted by Claude.