Repository navigation
feat(magpie): unify OpenViking memory and model management - #7290
Merged
Merged
Conversation
Declare VLM, VikingBot and activation groups for Magpie's native settings panel extension, reusing the host's rows, menus, switches and numeric fields. Preserve unset, explicit default and custom parameter values. Retain a localized standalone form for released Magpie versions and replace JSON textareas with validated controls. Save through the options bridge directly because sandboxed panels cannot submit HTML forms. Validation: syntax checks and all 35 bridge/activation tests passed; Chromium sandbox form tests passed in Chinese/English at wide/narrow widths. The actual native declaration passed embedded role-isolation and save tests, and was installed on dev with the companion Magpie build.
Add a positive-integer vlm.max_concurrent control to native Agent settings and the sidebar form. Preserve omission and journal the original value for disconnect restoration. Concurrency changes use the existing Root configuration save and verified restart flow. Reject the parameter for VikingBot, which has no corresponding request-concurrency setting. Document that semantic/Compile capacity is not a global gateway limit. Validation: syntax checks, all 37 adapter/activation tests, Chinese/English sandbox form checks, and native settings save checks passed. The dev server accepted concurrency=4 in dry-run validation. The updated plugin is installed on dev; its current value of 100 was preserved.
Ignore retained Bot model IDs outside independent mode and treat an empty independent ID as the Agent selection, keeping native mode switches usable. Persist the target, full-document fingerprint and revision of plugin saves. Report external pending restarts separately and recheck ownership inside the activation lock before any automatic restart. Recover ambiguous save responses by matching the complete intended document. Serialize stale-lock recovery so concurrent contenders cannot remove a new owner's lock. Ambiguous recovery-guard crashes fail closed; document recovery. Validation: syntax checks and all 42 adapter/activation tests passed. Five new regression checks fail against the old implementation. Coverage includes mode switches, external changes, lost save responses, restoration, activation target checks and deterministic competing stale-lock recovery.
Remove the custom Agent-panel declaration and the dependency on a modified Magpie application. Keep parameter configuration in the plugin's standard page, using the released options bridge and theme. Preserve model wiring, concurrency controls, verified activation and recovery inside the plugin. Freeze the plugin's own form during saves to retain the save-race fix without any application changes. Document the supported entry point and allow an explicit installed Bun path for offline isolated-host verification. Validation: syntax checks, all 42 bridge/activation tests, and Chinese/English Chromium form tests at wide/narrow widths passed. The isolated smoke passed against original Magpie 0.1.3493 on dev with zero inference calls. Dev now uses its original executable; the custom service override is removed, and the plugin update preserved options and OV configuration.
yufeng201
commented
Nov 10, 2026
yufeng201
commented
Nov 10, 2026
yufeng201
commented
Nov 10, 2026
yufeng201
commented
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Installing memory integration and model management separately produces two OpenViking entries. This change combines both into
@openviking/magpie-plugin@0.2.0: one installed entry with Agent and request-hook capabilities, retaining the middleware Discovery category.Users select the VLM model in Agents → OpenViking, with separate Query Planner and VikingBot model IDs configurable through the plugin's existing Options. The model adapter saves the gateway binding, automatically restarts OV, and verifies activation. Memory recall/capture/tools and model management have independent
memoryEnabled/modelsEnabledswitches. No configuration page, settings panel, or Magpie host changes are required.Human Involvement
Related Issue
N/A
Type of Change
Changes Made
@openviking/magpie-pluginpackage identity and prepare version 0.2.0; move the model adapter, Agent declaration, CLI and lifecycle tests into itsmodels/module.plugin.enabled: falsefor background model synchronization and automatic restart, including live flag changes; explicit recovery CLI commands remain available.queryMode(preserveby default,follow,independent),queryModelandqueryParametersin existing plugin Options. Independent Query validates its own catalog model/output limit; follow removes the optional section to use OV's native VLM fallback. Query-only changes use the same automatic restart verification.Testing
plugin.enabled: false: zero Root configuration writes, zero automatic restarts, original model retained.86a781074) has now been deployed in place to dev and Magpie restarted. Installed files match the package; plugin Options, selection and recovery records are unchanged; memory remains disabled and model management enabled. OV configuration/revision and process instance are unchanged, with no pending restart. Final interactive verification is left to the user.Checklist
Additional Notes
Prompt-cache utilization was investigated separately. This PR does not change prompt ordering, cache keys, routing affinity, or the extraction strategy.
Version 0.2.0 has not been published. The existing release workflow publishes changed versions only after merge to main. Root configuration/restart APIs are required for model management. Standalone Bot restart and Embedding/Rerank/Account overrides remain outside scope. Manual two-plugin migration instructions are included; do not install both old and unified model Agents simultaneously.