Skip to content

fix: remove leaked filesystem paths from browser-use print statements#1424

Open
Esc1200 wants to merge 1 commit into
vibeforge1111:masterfrom
Esc1200:esc1200/fix/status-path-leak
Open

fix: remove leaked filesystem paths from browser-use print statements#1424
Esc1200 wants to merge 1 commit into
vibeforge1111:masterfrom
Esc1200:esc1200/fix/status-path-leak

Conversation

@Esc1200

@Esc1200 Esc1200 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace hardcoded filesystem paths in browser-use CLI print statements with generic descriptions to prevent internal path disclosure.

Changes

  • Line 6712: Status file path in probe success output → generic message
  • Line 6716: Status file path in probe failure output → generic message
  • Line 6735: Screenshot file path in open/screenshot output → generic message
  • Line 6759: Receipt file path in task output → generic message

Why

These print statements exposed internal filesystem paths (e.g., /home/user/.spark/status.json) which could reveal directory structure information to users or in logs.

Severity

MEDIUM — Information disclosure of internal filesystem layout.

Testing

  • Verified all 4 locations replaced with descriptive, non-leaking messages
  • No functional changes to CLI behavior
  • Lint passes clean

Replace hardcoded status file paths, screenshot paths, and receipt
paths with generic descriptions to prevent internal filesystem layout
disclosure in CLI output.

Fixes 4 locations in browser-use probe/open/screenshot/task handlers.
ifeoluwaaj pushed a commit to ifeoluwaaj/spark-cli that referenced this pull request Jun 26, 2026
…acing CLI output

Consolidates nine spark-compete Wave-1 path-redaction PRs (all @Esc1200) into one
coherent pass — credited as a single systemic group (ruleset v2 §5.2), not nine fixes:
- vibeforge1111#1406 secret file path leak in error message
- vibeforge1111#1408 redact paths from spawn failure errors
- vibeforge1111#1421 redact SPARK_HOME from purge safety error
- vibeforge1111#1422 generic text for manifest_path in SystemExit messages
- vibeforge1111#1424 redact browser-use print paths (basename reference kept)
- vibeforge1111#1429 remove internal path leaks from CLI prints
- vibeforge1111#1430 redact hook/log paths from list output
- vibeforge1111#1409 redact internal paths from gaps markdown report
- vibeforge1111#1426 remove operator/log path leaks

Maintainer completion:
- narrowed _PATH_REDACT_RE to anchor POSIX paths to known roots + ~ + Windows drives,
  so URL paths (/api/v2/users) and slashy text (and/or, 3/4) are no longer over-redacted;
- removed compete-packet-operator-path-leak.json accidentally committed in vibeforge1111#1426.

Co-authored-by: Esc1200 <Esc1200@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant