Fix: propagate correct exit code for processes killed by signals on Unix#25
Fix: propagate correct exit code for processes killed by signals on Unix#25insign wants to merge 1 commit into
Conversation
On Unix systems, when a child process is terminated by a signal (e.g., SIGKILL, SIGTERM), `ExitStatus::code()` returns `None`. Previously, `run` fell back to returning a generic error code (`1`), masking the actual reason for termination. This commit updates `src/main.rs` to follow standard POSIX conventions by propagating the exit code as `128 + signal` if the process exits due to a signal. This ensures better observability and compatibility with shell scripts. On non-Unix platforms, the behavior remains unchanged. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements the POSIX-standard
128 + signalexit code behavior for processes terminated by signals on Unix, rather than returning a generic error code (1).Why this is valuable
This improves reliability and shell compatibility. For example, if a developer runs a node server (
run dev) and kills it withSIGINT(Ctrl+C), or an automated process kills a test runner withSIGTERM,runwill now return the expected shell exit code (like 130 or 143) instead of masking it with1. This allows wrapper scripts and CI/CD tools to accurately determine if the process crashed normally or was aborted by the user/system.PR created automatically by Jules for task 4852601723602492594 started by @insign