Skip to content

Fix: preserve session data during impersonation#24

Open
insign wants to merge 1 commit into
mainfrom
fix/preserve-session-data-803726232052966720
Open

Fix: preserve session data during impersonation#24
insign wants to merge 1 commit into
mainfrom
fix/preserve-session-data-803726232052966720

Conversation

@insign

@insign insign commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Este PR remove as chamadas agressivas de limpeza de sessão (Session::invalidate(), Session::regenerateToken() e Session::flush()) do método logoutAndDestroySession no PossessionManager. Isso é útil porque impede a destruição acidental de dados não relacionados à autenticação (como carrinhos de compras, progresso em formulários multi-etapas e mensagens flash) quando um usuário administrativo inicia ou encerra a personificação de outro usuário.

Justificativa de Valor Real:
A destruição completa da sessão quebrava o estado do sistema da perspectiva do usuário sempre que o recurso de personificação era utilizado. Como o Laravel já gerencia de forma segura a expiração e o logout através do método Auth::logout() (incluindo o re-uso ou limpeza do ID da sessão da perspectiva de segurança sem descartar a bag de sessão arbitrariamente), a remoção dessa limpeza garante que o sistema de personificação possa ser usado sem perdas de UX em aplicações complexas.

Arquivos alterados:

  • src/PossessionManager.php
  • tests/SessionFlushTest.php (novo teste para garantir o comportamento desejado)

PR created automatically by Jules for task 803726232052966720 started by @insign

…e flush

Co-authored-by: insign <1113045+insign@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant