Fix: Preserve session data during impersonation#23
Conversation
Removed aggressive session clearing operations from the PossessionManager to preserve unrelated user session data (like carts and intermediate states) during possess and unpossess. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR prevents the application from completely flushing the user's session when starting or stopping an impersonation. This is really useful because it preserves the user's workflow and existing session data (like shopping carts or form states) while still switching their authenticated context.
Changes:
Session::invalidate(),Session::regenerateToken(), andSession::flush()fromlogoutAndDestroySession().tests/SessionFlushTest.phpto ensure unrelated session data is retained across impersonation changes.PR created automatically by Jules for task 174245231779582888 started by @insign