Skip to content

Fix: Preserve session data during impersonation#23

Open
insign wants to merge 1 commit into
mainfrom
fix-session-flush-impersonation-174245231779582888
Open

Fix: Preserve session data during impersonation#23
insign wants to merge 1 commit into
mainfrom
fix-session-flush-impersonation-174245231779582888

Conversation

@insign

@insign insign commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR prevents the application from completely flushing the user's session when starting or stopping an impersonation. This is really useful because it preserves the user's workflow and existing session data (like shopping carts or form states) while still switching their authenticated context.

Changes:

  • Removed Session::invalidate(), Session::regenerateToken(), and Session::flush() from logoutAndDestroySession().
  • Added tests/SessionFlushTest.php to ensure unrelated session data is retained across impersonation changes.

PR created automatically by Jules for task 174245231779582888 started by @insign

Removed aggressive session clearing operations from the PossessionManager to preserve unrelated user session data (like carts and intermediate states) during possess and unpossess.

Co-authored-by: insign <1113045+insign@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant