Conversation
fantix
changed the title
fantix
changed the title
Catch replay mismatches before a run ends, preparing for hook lifecycle writes in #410.
fantix
force-pushed
the
fantix/workflow-terminal-replay-check
branch
from
September 29, 2026 19:05
d2819c1 to
3f14cbe
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workflow can return or raise before replay has checked all of its recorded events. For example, during local development:
The updated workflow can now return immediately, and the run can finish successfully without detecting the missing call.
This PR checks the remaining history after the workflow body and task cleanup finish. If it finds a mismatch, the run fails with
NondeterminismError, even if the body returned a value or raised a different exception. It uses the existing replay checks without resuming workflow code or delivering results to pending operations.This fixes a narrow edge case on its own, but it also lays the groundwork for #410, where we need to check existing history before writing pending hook registrations and disposals at the end of a run.