fix: destroy the read stream on 304 Not Modified - #236
Open
jaideeppyne wants to merge 1 commit into
Open
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
The handler opened the file before evaluating If-None-Match. On a 304 the stream was never piped or destroyed, so each cache hit leaked an FD until the process hit EMFILE. Fixes vercel#235.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235.
Summary
createReadStreamis destroyed on anIf-None-Matchhit.Why
The handler opened the file before evaluating the conditional request. On 304 the stream was never piped, so each cache hit leaked an FD. Under normal browser traffic that is most requests, until
EMFILE.Validation
yarn run build-views && yarn test-integration(71 passing)