Skip to content

readme: remove incorrect "not"#12310

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:readme_fix_sentence
Open

readme: remove incorrect "not"#12310
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:readme_fix_sentence

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

With a recent commit the following sentence was added to the readme:

Use coreutils-*-musl if coreutils-*-musl is not compatible with your system.

The sentence doesn't make sense. This PR removes the "not". However, it's also possible that the "not" is correct and the second coreutils-*-musl is incorrect.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 12.08%

❌ 2 regressed benchmarks
✅ 315 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 48.9 ms 50.9 ms -3.91%
Memory cp_recursive_deep_tree[(120, 4)] 562.5 KB 699.2 KB -19.55%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:readme_fix_sentence (373d88d) with main (40c36f6)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented May 15, 2026

Sorry. I typo.

Comment thread README.md
Bug reporters should use binary from latest commit.

Minimal compatible glibc version is same with ubuntu-latest runner. Use `coreutils-*-musl` if `coreutils-*-musl` is not compatible with your system.
Minimal compatible glibc version is same with ubuntu-latest runner. Use `coreutils-*-musl` if `coreutils-*-musl` is compatible with your system.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Minimal compatible glibc version is same with ubuntu-latest runner. Use `coreutils-*-musl` if `coreutils-*-musl` is compatible with your system.
Minimal compatible glibc version is same with ubuntu-latest runner. Use `coreutils-*-musl` if `coreutils-*-gnu` is not compatible with your system.

My understanding is that this was the likely intent, based on the conversation at #12005.

Comment thread README.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the README should document the exact minimum supported glibc version for coreutils compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants