Skip to content

date: fix build for cygwin#12309

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:date-cygwin
May 15, 2026
Merged

date: fix build for cygwin#12309
cakebaker merged 1 commit into
uutils:mainfrom
oech3:date-cygwin

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 15, 2026

Closes #12303

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review May 15, 2026 11:14
Comment thread src/uu/date/src/locale.rs Outdated
Comment thread src/uu/date/src/locale.rs Outdated
Comment thread src/uu/date/src/locale.rs Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will degrade performance by 19.55%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 316 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 562.5 KB 699.2 KB -19.55%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:date-cygwin (045e15d) with main (40c36f6)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit d09f351 into uutils:main May 15, 2026
170 of 171 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the date-cygwin branch May 15, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date: build failure of cygwin target

3 participants