HANDS: add realistic Boxer model and bounded arcade gore - #287
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullmode, including sprays, stains, gibs, fountains, and reversible decapitation proxies, while immediately clearing or suppressing graphic effects inreduced,off, and reduced-motion modesindex.html/assets/hands.js/assets/hands.cssdeployment contract, await texture readiness, and strengthen bundle URL and size gatesModel source: https://sketchfab.com/3d-models/boxer-84767168720948b38728ff78ee6f6090
Validation
uv run ruff check .uv run ruff format --check .uv run mypy src/uv run pytest tests/— 1,891 passednpm run typecheck— passednpm run test:run— 185 passednpm run build/npm run scan:build— exact three-file manifest passeduv run python scripts/hands_replay.py --check— deterministicc26c87d11ff0eab83c1921e3ec4f352bbe05cd50b3b3916a7bda1962790d94e2Bundle note
The required inline model and five textures increase
hands.jsto 5,624,575 bytes raw / 2,942,823 bytes at gzip level 9. Build and wheel checks enforce ceilings of 6,000,000 raw / 3,200,000 gzip bytes.