Repository navigation
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
Aoang
requested changes
Aug 6, 2026
Collaborator
There was a problem hiding this comment.
The standard encoding/hex library is very common, so I don't think we need to add unit tests for it. We can remove the internal/hex_test.go file.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. If there is no update within the next 7 days, this pr will be closed. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/tmthrgd/go-hexdependency with the standard libraryencoding/hexCloses #1385
Validation
gofmt -d internal/hex.go internal/hex_test.gogo test ./...go vet ./...go test -run '^$'in every nested moduletmthrgd/go-hexreferencesThe database-backed
driver/pgdriverruntime tests were not run because no local PostgreSQL service was available; their compile-only check passed, and CI supplies the required database services.