Skip to content

chore: replace go-hex with encoding/hex - #1407

Closed
giri256 wants to merge 1 commit into
uptrace:masterfrom
giri256:fix/stdlib-hex-1385
Closed

giri256 wants to merge 1 commit into
uptrace:masterfrom
giri256:fix/stdlib-hex-1385

Conversation

@giri256

@giri256 giri256 commented Jul 22, 2026

Copy link
Copy Markdown

Summary

  • replace the unmaintained github.com/tmthrgd/go-hex dependency with the standard library encoding/hex
  • remove the dependency from the root module and every nested module
  • add focused coverage for empty, single-write, and multi-write hex encoding

Closes #1385

Validation

  • gofmt -d internal/hex.go internal/hex_test.go
  • go test ./...
  • go vet ./...
  • compile-only go test -run '^$' in every nested module
  • verified the repository contains no remaining tmthrgd/go-hex references

The database-backed driver/pgdriver runtime tests were not run because no local PostgreSQL service was available; their compile-only check passed, and CI supplies the required database services.

Signed-off-by: p1 <giridharpavan593@gmail.com>
Comment thread internal/hex_test.go

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard encoding/hex library is very common, so I don't think we need to add unit tests for it. We can remove the internal/hex_test.go file.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. If there is no update within the next 7 days, this pr will be closed. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Sep 6, 2026
@github-actions github-actions Bot closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace unmaintained github.com/tmthrgd/go-hex with stdlib encoding/hex

2 participants