Skip to content

fix(dropdown): updated style based on --uc-radius - #1092

Merged
egordidenko merged 1 commit into
mainfrom
fix/drop-down-border
Sep 30, 2026
Merged

egordidenko merged 1 commit into
mainfrom
fix/drop-down-border

Conversation

@egordidenko

@egordidenko egordidenko commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Checklist

Summary by CodeRabbit

  • Style
    • Dropdown content now uses a border radius based on the app’s configured radius.

@egordidenko
egordidenko requested a balanced review from Copilot September 30, 2026 01:24
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: uploadcare/file-uploader/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: faa3213d-2614-48c4-8408-0f0d7ef6e953

📥 Commits

Reviewing files that changed from the base of the PR and between e854d2a and 0a97a2a.

📒 Files selected for processing (1)
  • src/blocks/DropDown/drop-down.css

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The dropdown content border radius now uses 1.5 times the --uc-radius custom property instead of a fixed 12px value.

Changes

Dropdown radius

Layer / File(s) Summary
Use the radius custom property
src/blocks/DropDown/drop-down.css
The dropdown content border radius now uses calc(var(--uc-radius) * 1.5) instead of 12px.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0a97a

The dropdown corners now follow the theme radius token instead of a fixed value. The variable is inherited in the normal component tree, so the merge risk is minimal.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains the template headings, but it provides no change summary, issue link, supporting evidence, or completed checklist information. Add a brief description of the CSS change. Add the related issue link, or state that no issue applies. Complete the tests, documentation, and changelog checklist items. The conventional commit title can satisfy the changelog requirement if …
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dropdown style fix and the use of --uc-radius.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Resolution

Add a brief description of the CSS change. Add the related issue link, or state that no issue applies. Complete the tests, documentation, and changelog checklist items. The conventional commit title can satisfy the changelog requirement if the repository accepts it; mark that item accordingly.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused styling change preserves the default radius while supporting configured radius themes.

Review effort: Balanced
Findings: None

What changed in this PR

Updates dropdown styling to respect the configurable global radius.

Changes:

  • Replaces the fixed 12px radius with 1.5 × --uc-radius.
File Description
src/​blocks/​DropDown/​drop-down.css Makes dropdown corner radius theme-aware.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@egordidenko
egordidenko requested a review from nd0ut September 30, 2026 01:29
@egordidenko
egordidenko merged commit d5a84ea into main Sep 30, 2026
10 checks passed
@egordidenko
egordidenko deleted the fix/drop-down-border branch September 30, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants