Skip to content

e2e: allow labeled pull requests to run E2E tests - #1508

Merged
denisonbarbosa merged 1 commit into
mainfrom
allow-e2e-tests-on-pr
Sep 29, 2026
Merged

denisonbarbosa merged 1 commit into
mainfrom
allow-e2e-tests-on-pr

Conversation

@denisonbarbosa

Copy link
Copy Markdown
Member

PR changes previously had no opt-in path through the Azure-backed E2E workflow. This allows us to easily trigger e2e runs using a PR diff rather than relying on workflow dispatches.

This is inspired by authd's e2e test runs, which can be triggered using PR labels.

@denisonbarbosa denisonbarbosa added the e2e-tests trigger e2e test run in the pull request label Sep 28, 2026
@denisonbarbosa
denisonbarbosa marked this pull request as ready for review September 28, 2026 11:30
@denisonbarbosa
denisonbarbosa requested a review from a team as a code owner September 28, 2026 11:30
@denisonbarbosa
denisonbarbosa requested a balanced review from Copilot September 28, 2026 12:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Manual dispatch compatibility and unnecessary Azure reruns need correction.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds label-triggered Azure E2E testing for same-repository pull requests.

Changes:

  • Runs E2E tests for PRs labeled e2e-tests.
  • Supports release selection through PR descriptions.
  • Documents the new workflow behavior.
File Description
.github/​workflows/​e2e-tests.yaml Adds PR triggers and release-matrix parsing.
e2e/​README.md Documents PR-triggered E2E runs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/e2e-tests.yaml
Comment thread .github/workflows/e2e-tests.yaml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Dependabot PRs pass the repository check but cannot access the required secrets, causing labeled runs to fail.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (2)

Comment thread .github/workflows/e2e-tests.yaml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow and documentation consistently implement the intended opt-in PR behavior without unresolved issues.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Comment thread .github/workflows/e2e-tests.yaml Outdated
PR changes previously had no opt-in path through the Azure-backed E2E
workflow. Let maintainers run coverage against the PR merge ref and
choose Ubuntu releases in the PR description.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The workflow runs PR merge refs with sensitive Azure and AD credentials, warranting final human security validation.

Review effort: Balanced
Findings: None

@denisonbarbosa
denisonbarbosa merged commit 411cc39 into main Sep 29, 2026
10 checks passed
@denisonbarbosa
denisonbarbosa deleted the allow-e2e-tests-on-pr branch September 29, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tests trigger e2e test run in the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants