Conversation
Each connection previously constructed its own QueryTimeoutManager, and since pre.36 that manager spawns a dedicated std::thread. The result was one OS thread per open connection, exhausting the process thread limit after a few hundred connections (pre.33 used a tokio task and opened 1500+ cleanly). Make QueryTimeoutManager a process-wide singleton with one background thread. Each registered timeout now carries a Weak<Connection> on its heap entry, so a single wheel interrupts the right connection regardless of how many are open. Connections no longer hold a manager or shut one down on close. Also add an integration test that opens many connections at once as a reproducer for the exhaustion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each connection previously constructed its own QueryTimeoutManager, and
since pre.36 that manager spawns a dedicated std::thread. The result was
one OS thread per open connection, exhausting the process thread limit
after a few hundred connections (pre.33 used a tokio task and opened
1500+ cleanly).
Make QueryTimeoutManager a process-wide singleton with one background
thread. Each registered timeout now carries a Weak on its
heap entry, so a single wheel interrupts the right connection regardless
of how many are open. Connections no longer hold a manager or shut one
down on close.
Also add an integration test that opens many connections at once as a
reproducer for the exhaustion.