Repository navigation
Fix pending count capped at 1, show count in sidebar bell - #25
Merged
Merged
Conversation
- Remove auto-clear-on-focus from enqueueCompletion() so the focused surface's completion stays pending and counts correctly - Clear pending completion on agent .started so a new prompt acts as the natural acknowledgement - Display numeric count next to the bell icon in the sidebar row
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request enhances the pending completion indicator UI to display a numeric count with accessibility labels, and refactors the completion handling logic to proactively clear pending state when a new agent activity event starts instead of reactively handling focused completions. Changes
Sequence Diagram(s)sequenceDiagram
participant AgentActivity as Agent Activity<br/>(External Trigger)
participant WorkspaceManager as WorkspaceManager
participant SurfaceManager as SurfaceManager
participant Notifications as Notification<br/>System
participant UI as Workspace<br/>Sidebar UI
AgentActivity->>WorkspaceManager: Activity Event Starts
rect rgba(100, 150, 255, 0.5)
Note over WorkspaceManager: New Proactive Clearing
WorkspaceManager->>SurfaceManager: clearPendingCompletion(workspace,<br/>surface, context)
WorkspaceManager->>Notifications: Remove pending<br/>notifications
end
Note over WorkspaceManager: Resume normal activity handling
rect rgba(100, 200, 100, 0.5)
Note over UI: Count Display
SurfaceManager->>UI: Update pending count
UI->>UI: Display count with<br/>bell indicator
end
Possibly Related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes