fix(developer): let an unlinked account delete its apps - #952
Merged
Merged
Conversation
Only editing is locked until GitHub is linked. The delete section shows again on an unlinked account's app, and the notice above it says editing is locked while deleting still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #949. An account without a linked GitHub account should be able to delete its apps. Only editing should be locked.
What changes
/apps/:id/editstill redirects to the app for an unlinked account.The API matches: for an unlinked account, edits answer 403
github_requiredand deletes are allowed.Checks
deno task format:svelte:checkpassesdeno fmt --check --config deno.jsonpassesdeno task check: 369 files, 0 errors, 0 warningsdeno lintpassesdeno task test: 198 tests passed