Skip to content

Mob interpolation occurs before aiStep on 26.3 - #349

Merged
tr7zw merged 1 commit into
tr7zw:mainfrom
MWHunter:interpolate-before-aistep
Oct 27, 2026
Merged

tr7zw merged 1 commit into
tr7zw:mainfrom
MWHunter:interpolate-before-aistep

Conversation

@MWHunter

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ac93462-153c-46c1-92ec-096736f67980
Commits

Reviewing files that changed from the base of the PR and between 89bdc1d and bb56ef1.

Files selected for processing: 1
  • src/main/java/dev/tr7zw/entityculling/mixin/ClientWorldMixin.java

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

For Minecraft 26.3+, basicTick now runs entity interpolation before incrementing tickCount and updating living-entity AI and hurt time.

Changes

Entity tick ordering

Layer / File(s) Summary
Reorder interpolation in basicTick
src/main/java/dev/tr7zw/entityculling/mixin/ClientWorldMixin.java
Interpolation now runs after setOldPosAndRot() and before tickCount, living-entity AI, and hurt-time updates.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

  • Issue 348: The issue describes the vanilla interpolation order before aiStep; this change places interpolation before living-entity AI updates.
  • Issue 347: The issue concerns state differences from skipped shulker ticks; this change reorders simulated ticks for living entities, including shulkers.

Suggested reviewers: tr7zw

Merge Risk: Minimal · up to bb56e

No supported issue requires changes before merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: moving mob interpolation before aiStep for Minecraft 26.3.
Description check Passed The description links to issue #348, which is directly related to the pull request and its interpolation change.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@tr7zw
tr7zw merged commit 177739f into tr7zw:main Oct 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants