Fix 'warning: literal string will be frozen in the future' introduced by ruby 3.4#126
Open
r-reload wants to merge 1 commit into
Open
Conversation
… by ruby 3.4: .freeze constants, rewrite some inject calls, and use pragma frozen_string_literal: false elsewhere
|
hi @toretore, we would also very much like this fixed and released :) +1 on the request from me. Is there anything I can assist you with to get this done? Happy to spend a bit of my time if wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 #20205 feature makes the barby gem output warnings when used, such as:
This PR is an attempt to fix the problem by:
Note: I ran the test suite with ruby 3.4, and remove all warnings of this type. This PR does NOT tackle other warnings introduced by Ruby 3.4