The Delete button does not have a description #334

Activity

1. konstrybakov commented on Jan 30, 2023

   

   konstrybakov

   on Jan 30, 2023

   More actions

   Hi @EntityPlantt, thanks for taking the time to open this issue! Feel free to open a PR with your suggestions!
2. wesbos commented on Jan 30, 2023

   

   wesbos

   on Jan 30, 2023

   Contributor

   More actions

   I think this is a bug @konstrybakov - the delete key has a description but isn't being displayed: https://github.com/toptal/keycodes/blob/main/lib/keycodes/with-events.ts#L340

   Same goes for the keys, PageUp, PageDown, End, Home, NumPad Equals, and probably a few more.

   👍React with 👍1Reacted by Palash Mondal
3. konstrybakov

   added

   bug

   good first issueGood for newcomersGood for newcomers

   on Jan 30, 2023
4. konstrybakov commented on Feb 1, 2023

   

   konstrybakov

   on Feb 1, 2023

   Last edited by konstrybakov

   More actions

   Hey, @EntityPlantt, thank you for bringing this to our attention. I've marked this as a bug and we will place it in our backlog. However, even though it is a bug, we are open to contributions!

   This 👇 shows the description though, so something is definitely wrong
   https://www.toptal.com/developers/keycode/delete

   Some strange behavior there 🪄
5. EntityPlantt commented on Feb 1, 2023

   

   EntityPlantt

   on Feb 1, 2023

   Author

   More actions

   Thanks for looking into the bug.
6. wesbos commented on Feb 1, 2023

   

   wesbos

   on Feb 1, 2023

   Contributor

   More actions

   I fixed it #338