Skip to content

PM-5368: show cancelled Marathon Match scoring in My Submissions - #7271

Open
jmgasper wants to merge 1 commit into
developfrom
PM-5368
Open

PM-5368: show cancelled Marathon Match scoring in My Submissions#7271
jmgasper wants to merge 1 commit into
developfrom
PM-5368

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

A Marathon Match submission whose scorer was stopped because the member submitted a newer solution stayed in the Preparing status with an empty Test Status column forever — exactly what the PM-5368 screenshots show. Members had no way to tell the run had been superseded rather than still being queued, and the report from the competitor was "still in preparing after more than 12 hours".

Root cause

The submission status helpers only recognized accepted and failed states, and the Test Status column only rendered IN PROGRESS, SUCCESS and FAILED. The CANCELLED test status that marathon-match-api-v6 now records was normalized away, so the row fell back to the generic preparing label.

What was changed

  • getSubmissionStatus returns a new isCancelled flag when a matching review summation reports a cancelled test run.
  • My Submissions list rows and the submission detail panel show a Cancelled status label, taking precedence over the accepted and preparing labels.
  • The Test Status column normalizes and renders CANCELLED with a new neutral cancelled icon (icons/cancelled.svg), styled grey so it reads as "stopped", not "failed" — the ticket is explicit that it should not be shown as failed.
  • The provisional/final score stays hidden for a cancelled run, since a cancelled scorer never produced a score.

Any added/updated tests

  • __tests__/shared/utils/challenge-detail/submission-status.test.js — new case covering that a cancelled review summation reports isCancelled instead of leaving the submission in the preparing state; the two existing toEqual cases were updated for the new flag.
  • __tests__/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx — new case covering that getSubmissionTestProgress surfaces a cancelled run with its process and progress.

Commands run: eslint and stylelint over the changed files, plus the My Submissions and submission-status jest suites (12 tests passing).

Related PRs

  • marathon-match-api-v6: cancel a member's in-flight MM scorer before scoring their newest submission
  • review-api-v6: allow CANCELLED through the member-safe review summation metadata allowlist
  • platform-ui: show cancelled Marathon Match test status in the work app submissions table

🤖 Generated with Claude Code

What was broken
A Marathon Match submission whose scorer was stopped because the member
submitted a newer solution stayed in the "Preparing" status with an empty Test
Status column forever, as shown in the PM-5368 screenshots. Members had no way
to tell that the run had been superseded rather than still being queued.

Root cause
The submission status helpers only recognized accepted and failed states, and
the Test Status column only rendered IN PROGRESS, SUCCESS and FAILED. The
CANCELLED test status that marathon-match-api-v6 now records was normalized away
and the row fell back to the generic preparing label.

What was changed
- getSubmissionStatus returns a new isCancelled flag when a matching review
  summation reports a cancelled test run.
- My Submissions list rows and the submission detail panel show a "Cancelled"
  status label, taking precedence over the accepted and preparing labels.
- The Test Status column normalizes and renders CANCELLED using a new neutral
  cancelled icon, and the provisional/final score stays hidden because a
  cancelled run never produced a score.

Any added/updated tests
- __tests__/shared/utils/challenge-detail/submission-status.test.js: new case
  covering that a cancelled review summation reports isCancelled instead of
  leaving the submission in the preparing state; existing cases updated for the
  new flag.
- __tests__/shared/components/challenge-detail/MySubmissions/SubmissionsList/index.jsx:
  new case covering that getSubmissionTestProgress surfaces a cancelled run.
@jmgasper
jmgasper requested a review from kkartunov as a code owner August 25, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant