Auto: sync versions [release-v1.44] - #5298
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
marvin-tigera
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are low-risk generated embed wrappers; the only feedback is minor naming/documentation clarity in the new admission embed helper.
Pull request overview
Automated update on release-v1.44 to sync in generated/versioned assets by adding small Go wrappers that expose embedded YAML content (CRDs and admission policies) as fs.FS for consumers.
Changes:
- Add
embed.gowrappers for Enterprise projectcalico.org v3 CRDs (v3.projectcalico.org) and v1 CRD-mode CRDs (v1.crd.projectcalico.org). - Add an
embed.gowrapper for Enterprise admission policy YAMLs underpkg/imports/admission/enterprise.
File summaries
| File | Description |
|---|---|
| pkg/imports/crds/enterprise/v3.projectcalico.org/embed.go | Introduces a small fs.FS accessor backed by go:embed for Enterprise v3 projectcalico.org CRD YAMLs. |
| pkg/imports/crds/enterprise/v1.crd.projectcalico.org/embed.go | Introduces a small fs.FS accessor backed by go:embed for Enterprise v1 CRD-mode CRD YAMLs. |
| pkg/imports/admission/enterprise/embed.go | Introduces a small fs.FS accessor backed by go:embed for Enterprise admission policy YAMLs. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+15
to
+16
| // Package admission serves the generated admission policies to the components | ||
| // that install them, so nothing has to keep a copy of its own. |
Comment on lines
+24
to
+30
| //go:embed *.yaml | ||
| var crds embed.FS | ||
|
|
||
| // FS returns the admission policy YAML in this directory. | ||
| func FS() fs.FS { | ||
| return crds | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
release-v1.44viamake gen-versions.Triggered by scheduled workflow.