Repository navigation
Add CEL validation for object names - #4280
Merged
caseydavenport merged 2 commits intoDec 9, 2025
Merged
Conversation
caseydavenport
force-pushed
the
casey-name-validation
branch
from
December 3, 2025 23:40
8599388 to
97ecbd6
Compare
tmjd
reviewed
Dec 4, 2025
tmjd
reviewed
Dec 4, 2025
tmjd
reviewed
Dec 4, 2025
caseydavenport
force-pushed
the
casey-name-validation
branch
from
December 5, 2025 22:23
0013025 to
d1ad297
Compare
tmjd
reviewed
Dec 8, 2025
tmjd
left a comment
tmjd
left a comment
Member
There was a problem hiding this comment.
A couple comments, I like the tests, those are nice and simple.
Member
Author
|
@tmjd thanks for the review! Pushed a commit to address your two comments |
tmjd
approved these changes
Dec 9, 2025
tmjd
left a comment
tmjd
left a comment
Member
There was a problem hiding this comment.
I would have been ok keeping the defer in the test code, I just didn't understand why it was there. Feel free to add it back if you'd like.
caseydavenport
force-pushed
the
casey-name-validation
branch
from
December 9, 2025 17:23
f7abe5f to
60e693e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can use CEL validation to enforce the singleton nature of many of our CRs.
This is hopefully the first of many CEL improvements we can make to our
API validation.
xref: https://kubernetes.io/docs/reference/using-api/cel/
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.