Repository navigation
Conversation
This is slightly nicer than the treat_new_as_changed job option, since it correctly displays the job state as NEW instead of CHANGED, and the content is displayed without the extraneous diff syntax.
| - ``diff_tool``: Command to a custom tool for generating diff text | ||
| - ``diff_filter``: :doc:`filters` (if any) to apply to the diff result (can be tested with ``--test-diff-filter``) | ||
| - ``treat_new_as_changed``: Will treat jobs that don't have any historic data as ``CHANGED`` instead of ``NEW`` (and create a diff for new jobs) | ||
| - ``treat_new_as_changed``: Will treat jobs that don't have any historic data as ``CHANGED`` instead of ``NEW`` (and create a diff for new jobs) (use the ``new`` reporter option to get content instead) |
There was a problem hiding this comment.
Should we just deprecate the old option? And/or change behavior of the old option (keeping it in for backwards compatibility, but warning) and maybe renaming it report_new or something?
There was a problem hiding this comment.
Some folks might have setup scripts parsing the old output (I don't), so I wouldn't change the behaviour of the treat_new_as_changed option, but I'm fine with deprecation and later removal of the old option.
There was a problem hiding this comment.
Its also possible that some folks want to only have to handle CHANGED status and diff output, rather than having to also handle NEW. That doesn't apply to my situation, but I can understand if some folks do want it.
thp
left a comment
There was a problem hiding this comment.
In general, I like the idea, but not sure about the new naming ("new" is such an overloaded term, maybe report_new or show_new or even just initial / report_initial? Or even report_first (since it's really about "having a history or not" rather than being "new" as such)
Fine to change the naming to your preferred one, all the options you proposed work for me, but I think I prefer |
This is slightly nicer than the treat_new_as_changed job option,
since it correctly displays the job state as
NEWinstead ofCHANGED,and the content is displayed without the extraneous diff syntax.