tests: fix flaky test in entity_store_compaction#4256
Merged
Conversation
The test's check could run before compaction process is completed, failing it. I've observed in the test report, that after failure, entity store was 4 entities (and only 1 was the compaction_count device), so the compaction completed, just a little later. To fix this, do the comparison using test in bash so it's subject to the retry policy. To confirm that it worked, I see the following in the report of some test runs after the fix: ``` cmd: ['/bin/sh', '-c', 'bash -c \'[ $(grep -c "compaction_count" /etc/tedge/.agent/entity_store.jsonl) -lt 10 ]\''], exit code: 1 ... cmd: ['/bin/sh', '-c', 'bash -c \'[ $(grep -c "compaction_count" /etc/tedge/.agent/entity_store.jsonl) -lt 10 ]\''], exit code: 0 ``` The retry is applied once, the compaction completes, and the test succeeds. Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
reubenmiller
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The test's check could run before compaction process is completed, failing it. I've observed in the test report, that after failure, entity store was 4 entities (and only 1 was the compaction_count device), so the compaction completed, just a little later.
To fix this, do the comparison using test in bash so it's subject to the retry policy. To confirm that it worked, I see the following in the report of some test runs after the fix:
The retry is applied once, the compaction completes, and the test succeeds.
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments