Skip to content

fix: pull the container image only once per process #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goloroden merged 2 commits into from
Aug 1, 2026
Merged

fix: pull the container image only once per process #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89d3a3
fix: pull the container image only once per process
goloroden Aug 1, 2026
10de10e
Merge branch 'main' into fix/pull-image-once
goloroden Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions eventsourcingdb/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import tarfile
import time
from http import HTTPStatus
from typing import ClassVar

import docker
import requests
Expand All @@ -16,6 +17,10 @@


class Container:
# Images already pulled in this process. Every container start would
# otherwise hit the registry again, even though the image is local.
_pulled_images: ClassVar[set[str]] = set()

def __init__(
self,
) -> None:
Expand Down Expand Up @@ -191,11 +196,18 @@ def start(self) -> "Container":
return self

def _pull_or_get_image(self) -> None:
image = f"{self._image_name}:{self._image_tag}"

if image in Container._pulled_images:
return

try:
self._docker_client.images.pull(self._image_name, self._image_tag)
except errors.APIError as e:
self._handle_image_pull_error(e)

Container._pulled_images.add(image)

def _handle_image_pull_error(self, error) -> None:
image_name = f"{self._image_name}:{self._image_tag}"
try:
Expand Down