publish_docs: check out submodules so WASM build can find ArduinoJson.h#699
Merged
Merged
Conversation
The Build browser WebAssembly decoder step added in #697 fails on the v2.3.0 release because actions/checkout@v4 does not initialize submodules by default, and src/arduino_json (which provides ArduinoJson.h) is a submodule. The other CI jobs that build C++ already pass submodules: recursive; this one was missed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build browser WebAssembly decoderstep added topublish_docs.ymlin Add in-docs web parser page powered by browser WASM #697 fails becauseactions/checkout@v4does not initialize submodules by default, andArduinoJson.hlives in thesrc/arduino_jsonsubmodule.fatal error: 'ArduinoJson.h' file not found(run).gcc,clang,xcodeinPR_build.yml, andpublish_npm.yml) already passsubmodules: recursive; this one was missed.Test plan
Create and publish documentationviaworkflow_dispatchagainstdevelopmentand confirm the WASM build step succeeds and the/parserpage deploys.🤖 Generated with Claude Code