Fix DecodeStatusCache status file writes#424
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DecodeStatusCache now rewrites
decoded_datasets.txtfrom in-memory state instead of opening the file inw+and reading from a truncated handle. Status updates go through a temp file plustf.io.gfile.rename(..., overwrite=True), and decoded dataset names are deduped while preserving first-seen order.Cache hits are now read-only.
TryLoadCache()returns the cached summaries without touching the status file, so looking up an existing dataset cannot corrupt the checkpoint key or append duplicates.Tests
python3 -m py_compile lingvo/core/program_utils.py lingvo/core/program_utils_test.pygit diff --check -- lingvo/core/program_utils.py lingvo/core/program_utils_test.py lingvo/core/BUILDlingvo.compatshimUSE_BAZEL_VERSION=5.3.0 npx -y @bazel/bazelisk test --experimental_repo_remote_exec //lingvo/core:program_utils_testdoes not reach analysis in this checkout because@rules_cc//cc:cc_library.bzlis not declared/resolved by the workspace.