Skip to content

Associate Combobox hints with form fields#3667

Merged
rossnelson merged 1 commit into
mainfrom
fix/combobox-hint-text
Jul 21, 2026
Merged

Associate Combobox hints with form fields#3667
rossnelson merged 1 commit into
mainfrom
fix/combobox-hint-text

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

Summary

Adds first-class hint text support to Combobox and associates hints and errors with the field using aria-describedby. Migrates the Cloud Run region hint to the new API.

Test plan

  • Unit tests — 2,251 passed, 1 skipped
  • Svelte check — 0 errors
  • Combobox Storybook tests — 12 passed
  • Formatting, ESLint, and Stylelint

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jul 13, 2026 8:29pm

Request Review

@temporal-cicd

temporal-cicd Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 11 errors in 2 files (1.2% of 895 total)

src/lib/holocene/combobox/combobox.svelte (10)
  • L155:4: Type 'null' is not assignable to type 'string'.
  • L158:4: Type 'null' is not assignable to type '"search" | "link" | "success" | "error" | "action" | "activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | "arrow-up" | "arrow-right" | "ascending" | ... 145 more ... | "xmark-square"'.
  • L160:4: Type 'null' is not assignable to type 'keyof T'.
  • L246:4: 'inputElement' is possibly 'null'.
  • L247:4: 'inputElement' is possibly 'null'.
  • L253:14: Argument of type 'string | T | undefined' is not assignable to parameter of type 'string | T'.
  • L258:14: Argument of type 'string | T | undefined' is not assignable to parameter of type 'string | T'.
  • L304:60: Function lacks ending return statement and return type does not include 'undefined'.
  • L397:10: Type 'HTMLLIElement | null' is not assignable to type 'HTMLLIElement'.
  • L397:43: 'menuElement' is possibly 'null'.
src/lib/holocene/combobox/combobox.stories.svelte (1)
  • L317:6: Element implicitly has an 'any' type because expression of type '"action"' can't be used to index type '{}'.

Generated by 🚫 dangerJS against 3e72fc1

@rossnelson
rossnelson marked this pull request as ready for review July 21, 2026 18:36
@rossnelson
rossnelson requested a review from a team as a code owner July 21, 2026 18:36
@rossnelson
rossnelson merged commit 40baeae into main Jul 21, 2026
20 checks passed
@rossnelson
rossnelson deleted the fix/combobox-hint-text branch July 21, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants