add features of describe, max skip, and poll fast-forward completion to time skipping - #11220
Merged
Conversation
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
from
July 22, 2026 21:03
5c270ea to
6eac8ee
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
from
July 22, 2026 21:13
8a39b67 to
d0f17c4
Compare
feiyang3cat
changed the title
feiyang3cat
changed the title
This was referenced Jul 22, 2026
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
from
July 23, 2026 18:17
d0f17c4 to
ab82eb1
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
2 times, most recently
from
July 30, 2026 19:38
5015e79 to
39d4566
Compare
feiyang3cat
added a commit
to temporalio/api
that referenced
this pull request
Jul 30, 2026
**What changed?** 1. add a max skip field to `TimeSkippingConfig` 2. add `TimeSkippingInfo` to `DescribeWorkflowExecution` (contains virtual current time and time-skipping runtime status) 3. add `PollWorkflowExecutionTimeSkipping` for fast-forward completion 4. comment refinements: remove the workflow keyword from time-skipping message comments under the common path 5. change `fast_forward` from a duration field to a message with both duration and id **Breaking changes** Change #5 **Server PR** temporalio/temporal#11220
temporal-cicd Bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jul 30, 2026
**What changed?** 1. add a max skip field to `TimeSkippingConfig` 2. add `TimeSkippingInfo` to `DescribeWorkflowExecution` (contains virtual current time and time-skipping runtime status) 3. add `PollWorkflowExecutionTimeSkipping` for fast-forward completion 4. comment refinements: remove the workflow keyword from time-skipping message comments under the common path 5. change `fast_forward` from a duration field to a message with both duration and id **Breaking changes** Change #5 **Server PR** temporalio/temporal#11220
feiyang3cat
marked this pull request as ready for review
July 30, 2026 19:54
1. add virtual time and running status in DescribeWorkflowExecution 2. rename TimeSkippingEnabled to WorkflowTimeSkippingEnabled 3. add default implementation of new API - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
1. Add a check to ensure fast_forward_id is not nil when setting the time-skipping config. 2. implement the poll api for time skipping - add a soft timeout waiting for fast-forward related notifications - fast-forward updates (either config or runtime state) will un-park all waiting requests - a workflow (chain of runs) completion will also un-park all waiting requests 4. add a generic PubSubNotifier and a noopNotifier so that this pattern can be reused - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
2 times, most recently
from
July 30, 2026 20:59
8ece8db to
93a35f8
Compare
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
from
July 30, 2026 21:09
93a35f8 to
5db0ac2
Compare
The root module moved to go.temporal.io/api v1.63.5-0.20260730194729-ba94140a7640 in 4c82315, but tests/mixedbrain is a separate module (replacing go.temporal.io/server => ../..) still pinning v1.63.4, so `go test` refused to run with "updates to go.mod needed" and mixed-brain-test failed with no test log.
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
from
July 30, 2026 21:48
2260a38 to
efca08d
Compare
simvlad
approved these changes
Jul 30, 2026
feiyang3cat
enabled auto-merge (squash)
July 30, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
related API change: temporalio/api#835