Fix concurrent request limiter charging non long-poll requests#11125
Open
simvlad wants to merge 1 commit into
Open
Fix concurrent request limiter charging non long-poll requests#11125simvlad wants to merge 1 commit into
simvlad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
ConcurrentRequestLimitInterceptor.Allow only exempted non-long-poll GetWorkflowExecutionHistory from the long-running concurrency quota. DescribeActivityExecution and DescribeNexusOperationExecution are also long-running only when their long_poll_token is set, but every call (including plain point-reads) was charged a token. Now all three are gated on their long-poll parameter.
Why?
Plain DescribeActivityExecution / DescribeNexusOperationExecution calls could be rejected with "namespace concurrent poller limit exceeded" under load despite not being long-running, and could starve real long-poll capacity.
How did you test it?
Potential risks
Seems safe, because the original intent is to charge only long polls