Migrate schedule tests to parallel suites#11102
Draft
stephanos wants to merge 21 commits into
Draft
Conversation
stephanos
changed the title
stephanos
commented
Jul 16, 2026
| env.Equal(enumspb.SCHEDULE_OVERLAP_POLICY_SKIP, describeResp.Schedule.Policies.OverlapPolicy) // set to default value | ||
| env.EqualValues(365*24*3600, describeResp.Schedule.Policies.CatchupWindow.AsDuration().Seconds()) // set to default value | ||
| env.Equal(enumspb.SCHEDULE_OVERLAP_POLICY_SKIP, describeResp.Schedule.Policies.OverlapPolicy) // set to default value | ||
| s.InDelta(365*24*3600, describeResp.Schedule.Policies.CatchupWindow.AsDuration().Seconds(), 0.001) // set to default value |
Contributor
Author
There was a problem hiding this comment.
changed from testify linter
stephanos
commented
Jul 16, 2026
| // memo while paused, so the listed status stays at RUNNING until unpause. | ||
| func testRecentActionsAdvanceWhilePaused(t *testing.T, newContext contextFactory) { | ||
| env := newScheduleEnv(t, scheduleCommonOpts(t)...) | ||
| func (s *ScheduleCHASMSuite) TestPausedBehavior() { |
Contributor
Author
There was a problem hiding this comment.
Retaining the original nested test structure
stephanos
commented
Jul 16, 2026
| @@ -4556,7 +4564,7 @@ type scheduleClosesCase struct { | |||
| } | |||
|
|
|||
| // testScheduleClosesFromIdle runs the idle-close matrix as parallel subtests. | |||
| func testScheduleClosesFromIdle(t *testing.T, newContext contextFactory) { | |||
Contributor
Author
There was a problem hiding this comment.
Made those methods on the CHASM suite now
stephanos
commented
Jul 16, 2026
| @@ -293,115 +296,59 @@ func completeRunningWorkflows(ctx context.Context, t *testing.T, env *testcore.T | |||
| return len(running) | |||
| } | |||
|
|
|||
| func TestScheduleCHASM(t *testing.T) { | |||
Contributor
Author
There was a problem hiding this comment.
These are 3 suites now
stephanos
marked this pull request as ready for review
July 16, 2026 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WISOTT