Block concurrent schedule changes during V2-to-V1 migration#11081
Open
chaptersix wants to merge 3 commits into
Open
Block concurrent schedule changes during V2-to-V1 migration#11081chaptersix wants to merge 3 commits into
chaptersix wants to merge 3 commits into
Conversation
chaptersix
changed the title
chaptersix
changed the title
chaptersix
marked this pull request as ready for review
July 15, 2026 22:12
| _ chasm.TaskInvocation, | ||
| _ *schedulerpb.InvokerExecuteTask, | ||
| ) (bool, error) { | ||
| if invoker.Scheduler.Get(ctx).WorkflowMigration != nil { |
Contributor
There was a problem hiding this comment.
nit: mind adding a log just to indicate a drop which is otherwise silent and possibly a tad confusing?
davidporter-id-au
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Migration pauses automated generation, but patch-triggered/backfill actions and already-ready invoker actions could still proceed while the migration task exported V2 state to V1. Those actions could be absent from the exported snapshot.
Validation
go test -tags test_dep ./chasm/lib/scheduler ./service/worker/schedulermake lint-code