Add system search attribute registration option for CHASM library#11080
Open
awln-temporal wants to merge 3 commits into
Open
Add system search attribute registration option for CHASM library#11080awln-temporal wants to merge 3 commits into
awln-temporal wants to merge 3 commits into
Conversation
rodrigozhou
requested changes
Jul 16, 2026
awln-temporal
force-pushed
the
awln-chasm-sa-system-override
branch
from
July 17, 2026 17:15
c8e4b5b to
29a0445
Compare
rodrigozhou
requested changes
Jul 17, 2026
Comment on lines
+255
to
+276
| case sadefs.WorkflowID: | ||
| return exec.WorkflowID, true | ||
| case sadefs.RunID: | ||
| return exec.RunID, true | ||
| case sadefs.WorkflowType: | ||
| return exec.TypeName, true | ||
| case sadefs.StartTime: | ||
| return exec.StartTime, true | ||
| case sadefs.ExecutionTime: | ||
| return exec.ExecutionTime, true | ||
| case sadefs.TaskQueue: | ||
| return exec.TaskQueue, true | ||
| case sadefs.ParentWorkflowID: | ||
| return exec.ParentWorkflowID, true | ||
| case sadefs.ParentRunID: | ||
| return exec.ParentRunID, true | ||
| case sadefs.RootWorkflowID: | ||
| return exec.RootWorkflowID, true | ||
| case sadefs.RootRunID: | ||
| return exec.RootRunID, true | ||
| default: | ||
| return nil, false |
Contributor
There was a problem hiding this comment.
Hm, I don't think we want to add the CHASM system search attributes here. I don't think it make sense for archetypes to override those.
Basically, we should add here those system search attributes that are not chasm system search attribute.
Comment on lines
+230
to
+239
| WorkflowID: {}, | ||
| RunID: {}, | ||
| WorkflowType: {}, | ||
| StartTime: {}, | ||
| ExecutionTime: {}, | ||
| TaskQueue: {}, | ||
| ParentWorkflowID: {}, | ||
| ParentRunID: {}, | ||
| RootWorkflowID: {}, | ||
| RootRunID: {}, |
| // attribute overrides onto the visibility request base, preserving the system column name. | ||
| // The set of supported fields must match sadefs.IsChasmOverridableSystem (enforced at | ||
| // registration and by TestChasmSystemOverrideWriteBridgeCoversOverridableFields). | ||
| func applyChasmSystemOverrides( |
Contributor
There was a problem hiding this comment.
nit: s/applyChasmSystemOverrides/applyChasmOverridenSystemFields
Contributor
Author
There was a problem hiding this comment.
yeah in general, renamed and moved this option to only apply to non-CHASM system search attributes, good callout.
| if chasmTaskQueue != "" { | ||
| requestBase.TaskQueue = chasmTaskQueue | ||
| } | ||
| // Apply registered CHASM system search attribute overrides (e.g. TaskQueue, ExecutionTime). |
Contributor
There was a problem hiding this comment.
Update comment: these are not Chasm system search attributes.
awln-temporal
force-pushed
the
awln-chasm-sa-system-override
branch
from
July 17, 2026 20:04
5b09670 to
86b86ec
Compare
rodrigozhou
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Support setting CHASM system search attribute overrides. Requires an additional field in CHASM search attribute mapper. On write, loop through any system search attributes and overwrite the visibility request base. An additional switch case must be added per system search attribute to support, since these values overwrite the visibility request base.
Why?
Allows users to reuse existing system columns for their CHASM search attributes.
How did you test it?