Extract helpers from versioning3 suite#11062
Open
stephanos wants to merge 20 commits into
Open
Conversation
stephanos
changed the title
stephanos
commented
Jul 14, 2026
|
|
||
| // Scope provides the context and test handles for a test or await attempt. | ||
| // It is useful for test helpers. | ||
| type Scope interface { |
Contributor
Author
There was a problem hiding this comment.
Scope lets shared helpers accept either a suite or an await attempt without carrying context and test handles separately.
stephanos
commented
Jul 14, 2026
| } | ||
|
|
||
| // Require returns assertions bound to the current attempt. | ||
| func (t *T) Require() *require.Assertions { |
Contributor
Author
There was a problem hiding this comment.
await.T satisfies Scope structurally, so nested helper assertions remain scoped to the current retry attempt.
stephanos
commented
Jul 14, 2026
| func (env *VersioningTestEnv) waitForTaskQueueVersioningInfo( | ||
| ctx context.Context, | ||
| tb testing.TB, | ||
| s parallelsuite.Scope, |
Contributor
Author
There was a problem hiding this comment.
Versioning helpers now take one Scope instead of separate context and test-handle parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Moved all versioning_3 helpers to
temporal_ver3/tests/versioning_test_env.go.Why?
Prepare for splitting suite.