Skip to content

Move dispatchResponseToError to common/nexus package - #10221

Merged
rkannan82 merged 8 commits into
mainfrom
kannan/move-dispatch-response-to-error
Jun 24, 2026
Merged

Move dispatchResponseToError to common/nexus package#10221
rkannan82 merged 8 commits into
mainfrom
kannan/move-dispatch-response-to-error

Conversation

@rkannan82

@rkannan82 rkannan82 commented May 11, 2026

Copy link
Copy Markdown
Contributor

What

Move dispatchResponseToError and startOperationResponseToError from service/history to common/nexus as exported functions.

Why

To reuse in standalone activities. See PR

How did you test it?

Existing unit tests.

🤖 Generated with Claude Code

rkannan82 and others added 2 commits May 11, 2026 11:41
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rkannan82
rkannan82 requested a review from yycptt June 10, 2026 22:33
@rkannan82
rkannan82 marked this pull request as ready for review June 10, 2026 22:33
@rkannan82
rkannan82 requested review from a team as code owners June 10, 2026 22:33
@rkannan82
rkannan82 requested a review from bergundy June 24, 2026 01:18
Comment thread common/nexus/dispatch_response.go Outdated
rkannan82 and others added 2 commits June 24, 2026 11:01
Clarifies that this function specifically converts a matching service
DispatchNexusTaskResponse to an error.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…emporalio/temporal into kannan/move-dispatch-response-to-error
@rkannan82
rkannan82 requested a review from a team as a code owner June 24, 2026 18:04
@rkannan82
rkannan82 force-pushed the kannan/move-dispatch-response-to-error branch from b049e20 to e9a4aa7 Compare June 24, 2026 18:08
@rkannan82
rkannan82 merged commit afa6604 into main Jun 24, 2026
49 checks passed
@rkannan82
rkannan82 deleted the kannan/move-dispatch-response-to-error branch June 24, 2026 18:43
rkannan82 added a commit that referenced this pull request Jun 24, 2026
Resolve conflicts from DispatchResponseToError -> MatchingDispatchResponseToError
rename (PR #10221).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephanos pushed a commit that referenced this pull request Jun 25, 2026
## What

Move `dispatchResponseToError` and `startOperationResponseToError` from
`service/history` to `common/nexus` as exported functions.

## Why

To reuse in standalone activities. See
[PR](#10218)

## How did you test it?

Existing unit tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
trangnguyenkp pushed a commit to trangnguyenkp/temporal that referenced this pull request Jul 9, 2026
## What

Move `dispatchResponseToError` and `startOperationResponseToError` from
`service/history` to `common/nexus` as exported functions.

## Why

To reuse in standalone activities. See
[PR](temporalio#10218)

## How did you test it?

Existing unit tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
spkane31 pushed a commit that referenced this pull request Jul 15, 2026
## What

Move `dispatchResponseToError` and `startOperationResponseToError` from
`service/history` to `common/nexus` as exported functions.

## Why

To reuse in standalone activities. See
[PR](#10218)

## How did you test it?

Existing unit tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants