feat(storage): support S3 IAM role credentials#3617
Open
nitin-bhadauria wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BACKEND_STORAGE_S3_USE_IAM_ROLEto enable the AWS SDK default credential provider chain for S3 storageTests
pnpm -F @teable/backend test-unit src/features/attachments/plugins/s3.spec.tspnpm -C apps/nestjs-backend exec eslint src/features/attachments/plugins/s3.ts src/features/attachments/plugins/s3.spec.ts --ext .ts,.js,.cjs,.mjs,.mdxNote:
pnpm -F @teable/backend typecheckstill fails on existing upstream baseline spec typing errors unrelated to this change.