server: export the not-found and already-set API metrics - #172
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The server counts not-found and already-set API results in countCallNotFound and countCallAlreadySet, but Metrics did not include either map, so they were never published. Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish the not-found and already-set API counters from
Server.Metrics.ServerincrementscountCallNotFoundfordb.ErrNotFoundresults andcountCallAlreadySetfordb.ErrVersionClaimedanddb.ErrInvalidVersionresults, butMetricsonly registered the calls, bad-request, forbidden and internal-error maps. The other two counters were collected and never exported.This change registers them as
counter_api_not_foundandcounter_api_already_set.Testing:
TestServerMetrics, which triggers a not-found result and an already-set result through the client and checks the exported counters.go test ./server/ -run TestServerMetricsfails with both new counters at 0. With the change, it passes.go test ./server/ ./db/passes.