Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

Add proxy support to sysdig client stack#236

Open
tsimp06 wants to merge 1 commit into
sysdiglabs:masterfrom
tsimp06:add-proxy-support
Open

Add proxy support to sysdig client stack#236
tsimp06 wants to merge 1 commit into
sysdiglabs:masterfrom
tsimp06:add-proxy-support

Conversation

@tsimp06

@tsimp06 tsimp06 commented Mar 16, 2023

Copy link
Copy Markdown

These changes will allow the initializer to add a proxy at initialization of the client to add to the request session, for use for all requests in that instantiation.

@tembleking

tembleking commented Mar 23, 2023

Copy link
Copy Markdown
Member

@tsimp06 Thank you for the submission, just a quick question: did you try to run the SDK with the environment variables HTTP_PROXY and HTTPS_PROXY configured? Maybe this would be enough instead of configuring the proxies as parameters.

@tsimp06

tsimp06 commented Mar 23, 2023

Copy link
Copy Markdown
Author

@tsimp06 Thank you for the submission, just a quick question: did you try to run the SDK with the environment variables HTTP_PROXY and HTTPS_PROXY configured? Maybe this would be enough instead of configuring the proxies as parameters.

Yes, and while that works, we don't want to use the proxy for ALL requests, as we are using private endpoints for other requests in the same test.

@tsimp06

tsimp06 commented Mar 28, 2023

Copy link
Copy Markdown
Author

@tembleking please see previous comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants