Repository navigation
feat(examples): add SvelteKit getting-started starter - #3892
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@caio-pizzol following up on your note on #3858: this is the SvelteKit starter reopened against |
Port the closed v1 starter (superdoc#3858) onto main's flat examples layout with SSR scoped off, readiness/export UX, and a Playwright smoke test.
Avoid colliding with custom-ui on 4177 when check:examples runs in parallel.
73f1ac9 to
9e115c5
Compare
Code Review by Qodo
View medium (1)🟠 **Medium** 1. Readiness remains enabled after failure
|
caio-pizzol
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @MeritonPylla! I pushed a few small updates to keep this consistent with our other quickstarts:
- Kept SSR enabled since SuperDoc starts inside
$effect. - Fixed
pnpm devso the document worker loads correctly. - Updated the README and test to match.
Everything is working locally. We’ll wait for CI and then this should be ready.
Looking good, thanks to you too |
Note: this ports only the public subtree changes from a mixed source commit (19 public paths, 2 non-public paths ignored). Ported-From-Source-Repo: superdoc/orbit Ported-From-Source-Commit: 547b1638c87eb58952b62110f54ffc88a0bed2fa Ported-Public-Prefix: superdoc/public
The examples catalog has React and vanilla quickstarts, but no SvelteKit starter. This adds one under
examples/sveltekit.The part worth a look is SSR. SuperDoc only runs in the browser, so if it loads during SSR you get
document is not defined. I didn't want to turn SSR off for the whole app, so I setssr = falseon just the editor route and mount the editor in a client-only$effect. Everything else in an app keeps server rendering.Registered it like the other v2 examples:
examples/README.md,go-links/links.json, andpublished-routes.json.Tested locally:
typecheck/build/ Playwright smoke pass, and it renders a real.docxwith a clean console.Re-opened against
mainfor v2 after #3858 (which targetedv1) was closed.