Skip to content

Bump Frontend dependencies - #46

Open
paulacarneiro wants to merge 5 commits into
masterfrom
pc/dependencies
Open

Bump Frontend dependencies#46
paulacarneiro wants to merge 5 commits into
masterfrom
pc/dependencies

Conversation

@paulacarneiro

@paulacarneiro paulacarneiro commented Jul 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update frontend dependencies

@DavideSilva
DavideSilva temporarily deployed to finiam-secrets-pr-46 July 14, 2022 16:58 Inactive
@DavideSilva
DavideSilva requested a deployment to finiam-secrets-pr-46 July 14, 2022 16:58 Abandoned
@DavideSilva
DavideSilva requested a deployment to finiam-secrets-pr-46 July 14, 2022 16:58 Abandoned
@DavideSilva
DavideSilva temporarily deployed to finiam-secrets-pr-46 July 14, 2022 17:00 Inactive
@zediogoviana

zediogoviana commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

There are some weird errors going on that deploy xD I'll need to call in @davelange as backup to see if he has already encountered The platform "linux" is incompatible with this module.

@davelange

davelange commented Jul 15, 2022

Copy link
Copy Markdown

I'd say this is the guilty error:
error @sveltejs/kit@1.0.0-next.372: The engine "node" is incompatible with this module. Expected version ">=16.9". Got "16.2.0"
We need to upgrade node.

@DavideSilva
DavideSilva temporarily deployed to finiam-secrets-pr-46 July 15, 2022 10:44 Inactive
@DavideSilva
DavideSilva temporarily deployed to finiam-secrets-pr-46 July 15, 2022 10:48 Inactive
zediogoviana
zediogoviana reviewed Jul 15, 2022
View reviewed changes
Comment thread .tool-versions Outdated
@@ -1,4 +1,4 @@
nodejs 16.14.0
nodejs 16.9.1

@zediogoviana zediogoviana Jul 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use one of the newer versions? Like 18 or something?

@davelange davelange Jul 15, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded to the current version and it failed:
Failed to install node version '18.6.0'
It worked locally, so I'm not sure what the issue is

@zediogoviana zediogoviana Jul 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some configuration on Netlify's side specifying an old version?

@DavideSilva
DavideSilva temporarily deployed to finiam-secrets-pr-46 July 15, 2022 12:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davelange davelange davelange left review comments
+1 more reviewer
@zediogoviana zediogoviana zediogoviana approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulacarneiro @zediogoviana @davelange @DavideSilva