feat(cli): define and enforce exit-code policy

[alexengrig]

Summary

Implements #15 by defining and enforcing a consistent CLI exit-code policy:

Code	Meaning
0	Success
1	Command outcome failure
2	CLI usage error

Changes

• Add CliExitCode enum and named constants in crates/adrman-cli/src/exit_code.rs
• Route all command handlers and parser error handling through the policy
• Classify adr new missing title and extra title tokens as usage errors (2)
• Parse adr check --format with clap value_parser so unsupported values are usage errors
• Add exit_code_command integration tests covering representative 0/1/2 cases
• Document the policy in README and OpenSpec (cli-root, cli-new)

Testing

• cargo test --workspace
• cargo clippy --workspace --all-targets
• cargo fmt --check

Closes #15

  

[alexengrig]

@cursor Thanks, this is close and matches the #15 policy direction well. One blocking issue remains: CI is failing in the clippy step, and the unused CheckOutputFormat import in main.rs appears to be the cause after run_check moved format parsing into cli.rs.

Please remove that unused import and rerun the checks.

[cursor]

Fixed the CI clippy failure and pushed to PR #34.

Changes:

• Removed CheckOutputFormat from main.rs by adding CheckArgs::output_format() in cli.rs (default format resolution stays next to clap parsing).
• Added #[allow(dead_code)] on the shared test CliRun impl — exit_code_command only uses a subset of helpers, which triggered -D warnings under --all-targets.

Checks passed:

• cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
• cargo test --workspace
• cargo fmt --check

  

[alexengrig]

Changes look good now. The previous unused import issue is fixed, the review thread is resolved, CI is green, and the exit-code policy implementation matches #15.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.