Repository navigation
feat: allow configuring the synchronous FSA worker timeout - #1298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1228.
Synchronous FSA operations currently time out after 100 ms even when the underlying storage operation is still progressing. This prevents the 300–500 ms writes described in the issue from completing through the synchronous adapter.
This adds an optional timeout (milliseconds) to
FsaNodeSyncAdapterWorker.start(url, dir, timeout)and forwards it toSyncMessenger. The default stays at 100 ms. The documentation shows how to increase it and notes that the calling thread remains blocked while waiting.Five deterministic tests cover responses within the default limit, the unchanged default timeout, a response after 200 ms with a 500 ms timeout, exceeding the configured limit, and forwarding the setting through the worker adapter. A separate reproduction failed with
Timeouton the unchanged base and passed after the fix.Validation on Linux / Node.js 24.21.0:
yarn buildyarn typecheckyarn prettier:checkyarn test: 100 suites passed; 1,618 tests passed, 17 skipped; 14 snapshots passed.The legacy TSLint executable is not available in the current workspace installation. No browser end-to-end test was run.
AI assistance: implementation and tests were prepared with OpenAI Codex.