Repository navigation
Move the smart-contracts skill to Protocol 29 and soroban-sdk 29 - #169
Merged
Merged
Conversation
Bump the version text and Cargo.toml pins from 27 to 29, and drop the "which mainnet runs" clause so the comment does not go stale again. soroban-sdk 28 deprecated update_current_contract_wasm and deploy_v2 (CAP-85), so the upgrade and factory examples now pass a ContractExecutable to update_current_contract and deploy_contract. soroban-sdk 28 also rejects a plain cargo build for a Wasm target, so the CI snippet and the eval compile checks now use stellar contract build. Add an upgrade eval scenario.
|
Contributor
Author
|
🤖 Automated message from the Stellar Triage Bot. Verification at
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated message from the Stellar Triage Bot.
Closes #162. Mainnet and Testnet run Protocol 29, so the smart-contracts skill now targets
soroban-sdk29.Cargo.tomlpins to 29. The pin comment no longer says which protocol Mainnet runs.update_current_contract(ContractExecutable::Wasm(..)).update_current_contract_wasmis deprecated sincesoroban-sdk28.deploy_contract, for the same reason (deploy_v2is deprecated).soroban-sdk28+ rejects a plaincargo buildfor Wasm. The CI snippet and the eval build checks now usestellar contract build.smart-contracts/05-upgrade-entrypoint.json.Verified: the new upgrade and factory code builds on
soroban-sdk29.0.1 forwasm32v1-nonewith no warnings. A plaincargo buildfails with "soroban-sdk requires stellar-cli v25.2.0+".