Fix listing export custom field data - #2982
Closed
Arafat-plugins wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #2983 to remove the codex/ branch prefix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
How to reproduce the issue or how to test the changes
This fixes the Directorist listing CSV export missing field data when exported listings do not all share the same directory/form field structure.
Previously, the exporter selected one row with the highest column count and used that row as the master CSV header. Fields that existed only on other listings or directories were dropped from the final CSV. This could hide saved listing data such as address, price, date, checkbox, and other custom field values.
This change builds the CSV header from the union of all exported row keys while preserving first-seen order, so fields from every exported listing are included. It also prepares serialized/array field values before CSV output, so checkbox/multi-value fields export as readable values instead of raw PHP serialized strings. CSV generation now uses PHP's native
fputcsv()handling for safer escaping of commas, quotes, and multiline content.Directorist -> Tools -> Exportand export listings.Local verification performed:
php -l includes/classes/class-listings-export.phpvendor\bin\phpcs.bat --standard=phpcs.xml includes/classes/class-listings-export.phpgit diff --checkDirectorist\Listings_Exporter::get_listings_data_as_csv_content(), verified all required columns and values were present, and confirmed serialized array output was not present. The temporary listing and directory were deleted after the test.Any linked issues
Fixes # https://team.sovware.com/support/directorist/3270
Screenshot
Checklist