Skip to content

feat: support container variables#1327

Merged
bahrmichael merged 12 commits into
mainfrom
bahrmichael/dynamic-containers
Jun 1, 2026
Merged

feat: support container variables#1327
bahrmichael merged 12 commits into
mainfrom
bahrmichael/dynamic-containers

Conversation

@bahrmichael
Copy link
Copy Markdown
Contributor

@bahrmichael bahrmichael commented Jun 1, 2026

This PR adds variable support for container images. The change is mainly to skip templated images on the initial static pull. They will still be loaded on demand when reaching the according step.

The batch spec can now reference images via {{ output.imageName }}.

bahrmichael and others added 11 commits June 1, 2026 08:58
Vendor github.com/sourcegraph/sourcegraph/lib at bdc2f4bb8b59f78f4fa8868b2690b673b41948d4 and restore src-cli compatibility for APIs still used locally.

Test Plan:

go test ./...

Amp-Thread-ID: https://ampcode.com/threads/T-019e8206-7c7d-76cb-9b08-b6e0df454e15
Co-authored-by: Amp <amp@ampcode.com>
…ic-containers

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e8259-56b5-711c-b1d6-377464e2d386

# Conflicts:
#	lib/batches/batch_spec.go
@bahrmichael bahrmichael marked this pull request as ready for review June 1, 2026 12:20
@bahrmichael bahrmichael requested a review from a team June 1, 2026 12:20
@bahrmichael bahrmichael enabled auto-merge (squash) June 1, 2026 15:17
@bahrmichael bahrmichael merged commit 4bcd4ce into main Jun 1, 2026
8 checks passed
@bahrmichael bahrmichael deleted the bahrmichael/dynamic-containers branch June 1, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants